Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #24671

Closed (moved)
(moved)
Open
Created Dec 19, 2017 by David Goulet@dgoulet🆘

sched: KISTLite should set an upper limit to write on the outbuf

Right now, for the KISTLite scheduler, the write limit on the outbuf for a channel is set to INT_MAX. This is crazy high and will bloat the outbuf if the channel is struggling to send out data on the wire or the socket is stuck.

Vanilla scheduler uses the num_cells_writeable() method to limit the amount it puts on the outbuf which is 32KB maximum.

KIST uses the kernel information for this limit.

This is very important that we actually put a limit in the outbuf because it keeps the cells in the circuit queue and that is handled by our OOM in case of memory pressure.

I suggest we simply use the channel_num_cells_writeable() for the upper limit when KISTLite is used.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking