Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #24754

Closed (moved)
Open
Opened Dec 28, 2017 by Trac@tracbot

Remove unnecessary heap allocations in Rust protover implementation.

https://github.com/frewsxcv/tor/compare/frewsxcv-protover-heap?expand=1

This is my first Tor patch! 🎉

I was working towards https://trac.torproject.org/projects/tor/ticket/24030 and noticed we do some unnecessary heap allocations via collect.

Even though this is a small change I'm mostly opening to see what the review/merge process is like. Also curious if small patches like this should be folded into larger patches as separate commits, or if it's okay to open individual tickets for them. If there's anything I'm doing wrong, let me know – I've done virtually no open source work outside of GitHub and am new to this Trac-based workflow.

Trac:
Username: frewsxcv

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.3.3.x-final
Milestone
Tor: 0.3.3.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#24754