Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #25081
Closed (moved) (moved)
Open
Issue created Jan 30, 2018 by Roger Dingledine@arma

use get_uptime() consistently

We have this nice function get_uptime() that shields the global variable stats_n_seconds_working from the rest of the Tor files.

But then we undermine that by saying

extern long stats_n_seconds_working;

in main.h and we just start using that variable directly all over.

There are a few lonely users of get_uptime().

We should move everybody over to using get_uptime, and get rid of the scary extern.

(Also check out how we're writing to the extern variable, in hibernate.c. There's no way that could confuse anybody down the road!)

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking