Skip to content

GitLab

Trac
Trac

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Closed (moved)
Opened by teor@teor

Create a new consensus method that ignores guardfraction votes

And here is how we remove code that depends on consensus method 20 (the guardfraction method):

  1. Create a new consensus method that ignores guardfraction votes. This new method can go in 034.

  2. Change all the code that says ">= MIN METHOD FOR GUARDFRACTION" to say ">= MIN METHOD FOR GUARDFRACTION and < MIN METHOD TO IGNORE GUARDFRACTION" (the new method). This disables guardfraction when the new method or any later method is used. See consensus method 28 for an example of the code and spec that we need to remove a consensus feature.

  3. When we will never revert to a lower consensus method (two releases later, 036), stop authorities voting for the buggy methods 20-28, and remove a whole bunch of old code, including all the guardfraction code.

  4. At that time, we might want to remove all the methods lower than 20, too. See #24378 (moved).

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information