allow for URLs that specify list of fingerprints

context: https://lists.torproject.org/pipermail/metrics-team/2018-March/000709.html

url could look like: ..fp=fp1,fp2,..

Also allow specifying the number of shown items per page.

consider this a low prio request (nothing happens if you don't implement it)

changed milestone to %Onionoo 1.16.0

added component::metrics/onionoo milestone::Onionoo 1.16.0 owner::karsten priority::low resolution::implemented reviewer::irl severity::minor status::closed type::enhancement labels

Let's consider implementing this in Onionoo, not Relay Search.

Replying to karsten:

Let's consider implementing this in Onionoo, not Relay Search.

I'm always for having things in Onionoo to keep Relay Search simpler.

Trac:
Component: Metrics/Relay Search to Metrics/Onionoo

How about we extend Onionoo's "lookup" parameter to support a list of comma-separated fingerprints in addition to a single fingerprint?

This should be quite simple to build while I'm looking into #23713 (moved) and #23914 (moved), so I'm just adding this to my list, too.

Trac:
Cc: N/A to metrics-team
Owner: metrics-team to karsten
Status: new to accepted

Please review commit c9218fb in my task-25448 branch.

Trac:
Status: accepted to needs_review

Trac:
Reviewer: N/A to irl

Is there a reason that we can't have the fingerprint parameter accept a list just as lookup does is in this patch?

Trac:
Status: needs_review to needs_revision

Oh, yes, the yet unspoken reason that we shouldn't keep both parameters. I meant to create a ticket for that, but forgot. Let me do that now, so that we can discuss the future of the fingerprint parameter, and then we can get back to this ticket.

Replying to karsten:

Oh, yes, the yet unspoken reason that we shouldn't keep both parameters. I meant to create a ticket for that, but forgot. Let me do that now, so that we can discuss the future of the fingerprint parameter, and then we can get back to this ticket.

Created #26919 (moved).

Replying to karsten:

Oh, yes, the yet unspoken reason that we shouldn't keep both parameters. I meant to create a ticket for that, but forgot. Let me do that now, so that we can discuss the future of the fingerprint parameter, and then we can get back to this ticket.

Ah ok. I didn't even realise we had that field until I saw it in the commit.

In which case, I shall finish the review.

Trac:
Status: needs_revision to needs_review

Looks good to me.

Trac:
Status: needs_review to merge_ready

Cool! Merged to master. Adding to the Onionoo 1.16.0 milestone as a reminder to document the change in metrics-web when putting out the next release. Closing. Thanks!

Trac:
Status: merge_ready to closed
Milestone: N/A to Onionoo 1.16.0
Resolution: N/A to implemented

closed

mentioned in issue #26919 (moved)