Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #25560

Closed (moved)
(moved)
Open
Created Mar 20, 2018 by Isis Lovecruft@isis

test all rust crates for realsies

After we merged #23881 (moved), it seems the tests in the tor_log crate aren't being run because there's an array in src/test/test_rust.sh that we didn't add the crate name to. I propose making that shell script automatically find the crates available and run their tests, e.g.

manifests=`find ${abs_top_srcdir:-.}/src/rust/ -mindepth 2 -maxdepth 2 -name 'Cargo.toml'`

(Currently, we're only running tests for crates="protover tor_util smartlist tor_allocate".)

As a side-note, I also think we should be calling cargo with --verbose so that our test logs actually tell us when something's wrong, e.g. for #24795 (moved) it would help.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking