Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #25773

Closed (moved)
Open
Opened Apr 11, 2018 by Matthew Finkel@sysrqb

Disable Speculative Connect and Download

As a follow up to #25770 (moved), it turns out Tor Browser actually begins (and sometimes completes) the download before the user can confirm they actually want the-thing. This manifests in #7449 (moved) and #11254 (moved) as the file being downloaded in /tmp (on Unix, or similar on other platforms) and then it is moved into the correct directory.

This provides an obvious performance improvement, especially for our use case. Unfortunately, this download begins before the user is even given the "where do you want this file saved" prompt, and I'm worried subtly downloading a file in the background is dangerous is some context, particularly some of our users.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#25773