Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #25859

Closed (moved)
Open
Opened Apr 20, 2018 by Georg Koppen@gk

Clean up zlib's build script

We should clean up the compile and link flags zlib build script:

  1. CFLAGS and LDFLAGS seem to be unused, rather LOC is taken to define those.
  2. Given 1) we could just assign the relevant flags to LOC and omit CFLAGS and LDFLAGS entirely AND we can omit spelling LOC out twice (once in the make command and once in the make install command).
  3. While we are at it, just doing a make install might be enough.
  4. No need to hard-code -j4.
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#25859