Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #25862

Closed (moved)
Open
Opened Apr 20, 2018 by Georg Koppen@gk

Clean up wrapper script/CFLAGS and friends mix on Windows

Our mix of wrapper scripts and usage of CFLAGS/LDFLAGS when compiling on Windows has grown over the years to a point where it gets confusing. We should get back to sanity here.

We needed the wrapper scripts to pass down all required flags to the depths of the Firefox build system, but meanwhile those scripts are used almost everywhere and CFLAGS/LDFLAGS additionally sometimes.

One option boklm brought up would be to use the CFLAGS/LDFLAGS defined in rbm.conf and enable those scripts only during Firefox's build.

Another just get rid of those wrapper scripts and fix the missing pieces in Firefox if those are still there.

At any rate, we should document where we need them in the first place to avoid lengthy digging in case someone is wondering in the future or now, while looking at our build scripts.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#25862