Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #25964

Closed (moved)
Open
Opened Apr 29, 2018 by teor@teor

Remove hs_index_t fetch, and use one of the stores instead

Split off from https://trac.torproject.org/projects/tor/ticket/23094#comment:9

Replying to [#23094 (moved):comment:3 asn]:

After our #23387 (moved) refactoring of hsdir index logic Nick suggested that we don't need to keep all 3 around in memory, since two of them are always identical: https://oniongit.eu/asn/tor/merge_requests/6#note_1201

We need to:

  • analyse the state machine of fetch, store_first, and store_second to make sure that fetch is always equal to store_first or store_second
  • work out the condition that we can use to select betweeen store_first or store_second when we want fetch
  • write a function that produces fetch from a hsdir_index_t, and use it instead of fetch
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#25964