Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #25987

Closed (moved)
Open
Opened May 01, 2018 by Nick Mathewson@nickm🐙

Allow controller to receive log messages from outside main thread

Our existing callback system doesn't allow this, but actually it would be pretty easy to take care of.

The trick here would be:

  1. to make it so that the flush_queued_events_event uses the alert_sockets_create() mechanism, so it can be turned on from another thread.
  2. To remove the check for whether we're in the main thread from control_event_logmsg().

I think this would be pretty simple -- maybe a couple hours of work -- but we should consider it only for 0.3.5, since it has potential to be very destabilizing if we mess it up.

Found while working on #25951 (moved)

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#25987