client: ControlPort set doesn't mean you're a client

Splitting from #19665 (moved) to avoid confusion.

This ticket is solely to make a patch so that when the ControlPort is set (Unix or not), we do not consider it as a client with any_client_port_set().

changed milestone to %Tor: 0.3.4.x-final

added 034-roadmap-subtask component::core tor/tor milestone::Tor: 0.3.4.x-final owner::dgoulet parent::25500 priority::medium resolution::fixed reviewer::nickm severity::normal status::closed tor-client tor-httptunnel type::defect labels

See branch ticket26062_034_01 ONLY for 034.

Following teor's comment from #19665 (moved):

We should split off 59a32e5b4ff210b95bbed294cdc787cb75539da5 into a separate ticket and backport it to 0.2.9 and later. Otherwise, relays with the control port open will warn based on the client required protocols list.

Here is the 029 branch for the backport and should be merged forward up to 033: ticket26062_029_01. There is a possible very trivial conflict since we added HTTPTunnelPort_set later on. I'll let that exercise to the mergerer :).

Trac:
Keywords: N/A deleted, tor-client added
Status: assigned to needs_review
Reviewer: N/A to nickm

lgtm; merged to 029 and forward!

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

Trac:
Keywords: tor-client deleted, tor-client tor-httptunnel added

closed

mentioned in issue #27849 (moved)

moved to tpo/core/tor#26062 (closed)