Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #26257

Closed (moved)
Open
Opened May 31, 2018 by Isis Lovecruft@isis

tor-browser-builder might want to not build rustc

As part of #25977 (moved), teor and I were looking into how rustc is being called and built, and we noticed that the binary for 1.24.1 is downloaded and then used to compile 1.25.0. The network team's current policy is to continue using whatever rustc is the current stable until "some distro we care about" releases a new OS version which freezes the rustc they distribute. Additionally, as of eight months or so (sometime between 1.19 and 1.20) ago, the latest nightly is used to compile the next night's nightly, so it's no longer always the case that the last version will compile the current version (meaning you're probably going to end up rabbitholing each time a new stable is released to figure out which nightly you need to somehow get a copy of to build with). Additionally, on a more theoretical note, I'm not certain what we're getting in terms of Trusting Trust attacks by building the compiler only once, versus just downloading the one we need to use.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#26257