Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #26404

Closed (moved)
Open
Opened Jun 18, 2018 by Matthew Finkel@sysrqb

Fixup commits for unused symbols

Some Tor Browser patches result in unreachable and/or unused code. This isn't a problem, in general, but when Firefox is built with -Werror, this causes a compile-time build failure. I'd like to fix these failures in our tree so we can begin pushing Try builds for our entire patchset.

This is step 0 on the larger/grander path of running the entire Firefox test suite against Tor Browser. Currently, too many unit tests fail when run on Tor Browser's patches, so this will not be useful (by itself) right now.

To be clear, I'm not sure if we should patch every unit test failure or if we should write a script that fetches the results and tells us if any failures were not expected - but this is a different topic.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#26404