hs: Adding client authorization through control port on an existing service fails
(Comes from reported issue in #26776 (moved)).
The scenario is this:
You have a configured HiddenService that has been configured through the control port (
SETCONF) without client authorization.
From the control port, you then
SETCONFthat same hidden service directory but with client authorization this time. The service will still be reachable without the client authorization that has just been set up.
The issue I believe comes from our transition from staging to the ready service list. See the crazy function
rend_service_prune_list_impl_() for v2, we keep the introduction points alive even if we now have client authorization. Not good...