Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #27173
Closed
Open
Issue created Aug 16, 2018 by dmr@dmr

Unstable unit tests in control.controller

#27053 (closed) brought about some changes to stem's controller's event handling.

Unfortunately the tests for that are a bit unstable - sometimes failing. Instead of letting that ticket drag on, the work is being moved to a new ticket for better clarity.

The history behind that is mostly in #27053 (closed), so refer there. A few parts were discussed over IRC, however, so that context will be filled in below...

From [ticket:27053#comment:14]

[...] The good news is that I figured out the python3 mock issue you found. Turns out there's a difference between PyPI and Python3's mock modules. Fixed...

https://gitweb.torproject.org/stem.git/commit/?id=e75cf25

I confirmed that this works for me.

From [ticket:27053#comment:15] (the latest comment at time of writing):

Hi Dave, think I got it but tough to be sure. Does this do the trick for you?

https://gitweb.torproject.org/stem.git/commit/?id=abc6f29

Tests are still failing as of this revision, still giving AssertionError: Expected 'mock' to be called once. Called 0 times. for py27. It seems to be more stable, now failing at ~5-10% rate instead of 25-40%. //(Rate not scientific)//

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking