Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #27299

Closed (moved)
Open
Opened Aug 24, 2018 by George Kadianakis@asn

hsv3: Clarify timing sources around hsv3 code

A big source of bugs and confusions (e.g. #26980 (moved), #26930 (moved)) in the HSv3 code stem from the fact that it uses various timing sources to compute time periods, SRV, etc. Some parts of the code use time(NULL), others use the current consensus valid-after, and others use the voting-schedule.

The code is currently not clear in which timing source is used in each case. As an example, some functions take as input now but they only use it to get a live consensus to use its valid-after, but that may confuse a reader that the now is used as the time source (e.g. should_rotate_descriptors() that caused the #26930 (moved) confusion).

We should try to clarify and improve the function signatures around the HSv3 codebase on this regard.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#27299