Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #27325

Closed (moved)
Open
Opened Aug 26, 2018 by rl1987@rl1987

Rework NETINFO cell parsing and generation with trunnel

In channel_tls_process_netinfo_cell() we have:

1720   /* Decode the cell. */
1721   timestamp = ntohl(get_uint32(cell->payload));
1722   if (labs(now - chan->conn->handshake_state->sent_versions_at) < 180) {
1723     apparent_skew = now - timestamp;
1724   }
1725 
1726   my_addr_type = (uint8_t) cell->payload[4];
1727   my_addr_len = (uint8_t) cell->payload[5];
1728   my_addr_ptr = (uint8_t*) cell->payload + 6;
1729   end = cell->payload + CELL_PAYLOAD_SIZE;
1730   cp = cell->payload + 6 + my_addr_len;

and in connection_or_send_netinfo() we write the cell to connection buffer. Trunnel should be used.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.4.0.x-final
Milestone
Tor: 0.4.0.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#27325