Skip to content

GitLab

Trac
Trac

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Closed (moved)
Opened by George Kadianakis@asn
Report abuse

Improve some v3 onion logs

I've been debugging lots of v3 logs lately and I noticed a few issues with them that can be improved:

set_descriptor_revision_counter(): Encrypted revision counter 118682 to -403149886

no need for %ld there, it's an uint64_t.

  1. On the client side when we fetch descriptors we have the following log message that displays the onion address and blinded key as a base64 instead of the typical base32. We should unify the format to make grep easier:
[info] directory_launch_v3_desc_fetch(): Descriptor fetch request for service khXWrMUXYYW1so9/CIWe5kI7+nxcSYO9zd4Edl2IIz8 with blinded key QvyLoKg/B6musSsNfL4vMk2wD2HpiDsTU3gM7kY41Sg to directory $C0B7413D690411DF5D2B0D838F56792312697122~minitor at 185.143.62.9
To upload designs, you'll need to enable LFS. More information