Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #27717

Closed
Open
Created Sep 14, 2018 by Damian Johnson@atagar

Report tor segfaults when integ testing

From time to time Stem's integration tests crash tor (for example, #27500 (moved)). When this happens our test output is pretty confusing since from the point of the crash onward we fail with generic 'cannot connect to tor' errors.

There's two issues here...

  1. Our test output doesn't indicate that tor crashed.

  2. When reporting tor segfaults we need its stacktrace, which is swallowed by our tests.

We should adjust our test's get_tor_controller() helper to check if tor is still alive, failing the test with a clearer message if it isn't and providing the tor stacktrace at the end of the test run.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking