Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #27739

Closed (moved)
Open
Opened Sep 17, 2018 by Trac@tracbot

rust protover_all_supported() accepts too-long protocol names

569b4e57e23d728969a12751afc6b45f32d0f093 was fixing #25517 (moved) but kept the old behavior of allowing protocol names of any length for protover_all_supported(). That's the reason this unit test was failing, and ended up being disabled on rust builds with a ??? comment of confusion.

The reason given in the commit for this behavior was in order to maintain compatibility with consensus methods older than 29. but the corresponding C code change never made any exception like this.

Trac:
Username: cyberpunks

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#27739