Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #2780

Closed
Open
Opened Mar 21, 2011 by Mike Perry@mikeperry

Investigate Torbutton translation input validation issue

We had a random anonymous person show up on IRC who pointed out that Transifex was not filtering their input for XSS or other attacks. While this is bad for our website, it is potentially even worse for Torbutton. XUL XSS means arbitrary code execution.

I spoke with Dan Veditz and he both half-chastised me for trusting this input, and also explained the history Mozilla went through before they managed to make Personas safe to deploy. DTD elements can carry arbitrary XUL elements. Properties are much less risky unless you use them as .innerHTML in DOM manipulations.

I also tried to see if I could "break out" of a DTD element used inside an attribute by closing the quote and injecting a script attribute. I could not.

I believe this means that only two of our DTD elements should actually be vulnerable to this.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#2780