Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #27918

Closed (moved)
Open
Opened Sep 30, 2018 by pastly@pastly

Add types to some new arguments

Because if you don't, they default to strings and that's not good.

$ sbws generate -n 1
[... snip ...]
Traceback (most recent call last):
  File "/home/matt/src/simple-bw-scanner/venv-editable/bin/sbws", line 11, in <module>
    load_entry_point('sbws', 'console_scripts', 'sbws')()
  File "/home/matt/src/simple-bw-scanner/sbws/sbws.py", line 75, in main
    exit(comm['f'](*comm['a'], **comm['kw']))
  File "/home/matt/src/simple-bw-scanner/sbws/core/generate.py", line 99, in main
    min_num=args.min_num)
  File "/home/matt/src/simple-bw-scanner/sbws/lib/v3bwfile.py", line 474, in from_results
    min_num)
  File "/home/matt/src/simple-bw-scanner/sbws/lib/v3bwfile.py", line 279, in from_results
    min_num)
  File "/home/matt/src/simple-bw-scanner/sbws/lib/v3bwfile.py", line 326, in min_num_results
    if len(results) > min_num:
TypeError: unorderable types: int() > str()

-p, -a, and -n all need a type I bet.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
sbws: 1.0.x-final
Milestone
sbws: 1.0.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#27918