Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #28012

Closed (moved)
Open
Opened Oct 11, 2018 by rl1987@rl1987

shellcheck: updateRustDependencies.sh issues

Shellcheck (​​​​​​https://github.com/koalaman/shellcheck) finds the following issues:



In updateRustDependencies.sh line 23:
HERE=`dirname $(realpath $0)`
     ^-- SC2006: Use $(..) instead of legacy `..`.
              ^-- SC2046: Quote this to prevent word splitting.
                         ^-- SC2086: Double quote to prevent globbing and word splitting.


In updateRustDependencies.sh line 24:
TOPLEVEL=`dirname $(dirname $HERE)`
         ^-- SC2006: Use $(..) instead of legacy `..`.
                  ^-- SC2046: Quote this to prevent word splitting.
                            ^-- SC2086: Double quote to prevent globbing and word splitting.


In updateRustDependencies.sh line 27:
CARGO=`which cargo`
      ^-- SC2006: Use $(..) instead of legacy `..`.
       ^-- SC2230: which is non-standard. Use builtin 'command -v' instead.


In updateRustDependencies.sh line 30:
    printf "Error: Couldn't find workspace Cargo.toml in expected location: %s\n" "$TOML"
                                                                              ^-- SC1117: Backslash is literal in "\n". Prefer explicit escaping: "\\n".


In updateRustDependencies.sh line 34:
    printf "Error: Couldn't find directory for Rust dependencies! Expected location: %s\n" "$VENDORED"
                                                                                       ^-- SC1117: Backslash is literal in "\n". Prefer explicit escaping: "\\n".


In updateRustDependencies.sh line 38:
    printf "Error: cargo must be installed and in your \$PATH\n"
                                                             ^-- SC1117: Backslash is literal in "\n". Prefer explicit escaping: "\\n".


In updateRustDependencies.sh line 41:
if test -z `cargo --list | grep vendor` ; then
           ^-- SC2046: Quote this to prevent word splitting.
           ^-- SC2006: Use $(..) instead of legacy `..`.


In updateRustDependencies.sh line 42:
    printf "Error: cargo-vendor not installed\n"
                                             ^-- SC1117: Backslash is literal in "\n". Prefer explicit escaping: "\\n".


In updateRustDependencies.sh line 45:
$CARGO vendor -v --locked --explicit-version --no-delete --sync $TOML $VENDORED
                                                                ^-- SC2086: Double quote to prevent globbing and word splitting.
                                                                      ^-- SC2086: Double quote to prevent globbing and word splitting.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.4.0.x-final
Milestone
Tor: 0.4.0.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#28012