Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #28090

Closed (moved)
(moved)
Open
Created Oct 17, 2018 by David Goulet@dgoulet🆘

Keepalive padding cell bypasses the cell scheduler

When sending a keepalive cell, we look if the connection outbuf is empty but with the KIST scheduler, that buffer is optimized to be emptied very quickly.

That cell should be able to ask the scheduler if it can queue cells in the outbuf. In an ideal world, that cell would be handled by the scheduler but since it is not a circuit level "cell", we can not quickly fix that.

The fix for padding cell is to ask the scheduler, for a specific channel, if it can queue in the outbuf. The KIST scheduler would do two things: check for pending cells and if the kernel would allow it (tcp buffer size).

This made the #28089 (moved) issue more pathological.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking