Improve getter names for boolean fields in metrics-lib
This ticket is created from #24419 (moved). #24419 (moved) notes that not all Onionoo methods could be changed to the isXY() pattern for boolean getter methods due to interfaces such as org.torproject.descriptor.NetworkStatusEntry. This ticket is to update metrics-libs accordingly. From #24419 (moved):
- I did not change src/test/org/torproject/metrics/onionoo/updater/DummyStatusEntry's "getUnmeasured()" to "isUnmeasured()" because the interface org.torproject.descriptor.NetworkStatusEntry requires it, and I figured org.torproject.descriptor is outside the scope of this ticket.
Agreed. We'd first have to change metrics-lib interfaces, put out a new major metrics-lib release, and then update the tests in Onionoo. Worth doing, though we would ideally combine this with other changes that require a major metrics-lib version bump.