Tinytest library leaks out into non-test codebase
This isn't a bug per se, rather a peculiarity in the code organization that I've encountered, which I think is accidental. Please correct me if I'm wrong.
I've been trying to wrap the 0.3.5 series of Tor in Go (https://github.com/ipsn/go-libtor). It's working properly as far as I can tell, just making my final tweaks before pushing it. To keep my wrapper small, I've discarded some of the sources that are not relevant for building the library, namely src/tools and src/test.
To my surprise, my build failed (it worked correctly for 0.3.3), and it turned out that the tinytest library (at least half of it) is in src/ext, which refers to the src/test folder that I just deleted (the test folder refers to tinytest, circular dependency, but that's beyond the point here).
Working around it wasn't too big of a deal, I just ignored the tinytest files, but was wondering if this was an accidental leakage of test files into the library part, adding a dependency to the tests? Shouldn't the 4 tinytest files from src/ext be moved into src/test?
Trac:
Username: karalabe