Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #29060

Closed (moved)
Open
Opened Jan 11, 2019 by rl1987@rl1987

shellcheck: test-network.sh issues


In test-network.sh line 8:
if [ -d "$CHUTNEY_PATH" -a -x "$TEST_NETWORK" ]; then
                        ^-- SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.


In test-network.sh line 19:
myname=$(basename $0)
                  ^-- SC2086: Double quote to prevent globbing and word splitting.


In test-network.sh line 23:
ORIGINAL_ARGS="$@"
              ^-- SC2124: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.


In test-network.sh line 55:
    if [ -d "$BUILDDIR/src/core/or" -a -d "$BUILDDIR/src/tools" ]; then
                                    ^-- SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.


In test-network.sh line 60:
    elif [ -d "$PWD/src/core/or" -a -d "$PWD/src/tools" ]; then
                                 ^-- SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.


In test-network.sh line 76:
if [ ! -d "$CHUTNEY_PATH" -o ! -x "$CHUTNEY_PATH/chutney" ]; then
                          ^-- SC2166: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.


In test-network.sh line 80:
    elif [ -d "$TOR_DIR" -a -d "$TOR_DIR/../chutney" -a \
                         ^-- SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.
                                                     ^-- SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.


In test-network.sh line 97:
if [ -d "$CHUTNEY_PATH" -a -x "$TEST_NETWORK" ]; then
                        ^-- SC2166: Prefer [ p ] && [ q ] as [ p -a q ] is not well defined.


In test-network.sh line 102:
    exec "$TEST_NETWORK" $ORIGINAL_ARGS
                         ^-- SC2086: Double quote to prevent globbing and word splitting.
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.4.1.x-final
Milestone
Tor: 0.4.1.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#29060