Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #29068

Closed (moved)
Open
Opened Jan 11, 2019 by rl1987@rl1987

shellcheck: zero_length_keys.sh issues


In zero_length_keys.sh line 22:
if [ $# -eq 0 ] || [ ! -f ${1} ] || [ ! -x ${1} ]; then
                          ^-- SC2086: Double quote to prevent globbing and word splitting.
                                           ^-- SC2086: Double quote to prevent globbing and word splitting.


In zero_length_keys.sh line 34:
DATA_DIR=`mktemp -d -t tor_zero_length_keys.XXXXXX`
         ^-- SC2006: Use $(..) instead of legacy `..`.


In zero_length_keys.sh line 43:
trap "rm -rf '$DATA_DIR'" 0
              ^-- SC2064: Use single quotes, otherwise this expands now rather than when signalled.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.4.1.x-final
Milestone
Tor: 0.4.1.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#29068