Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #29125
Closed (moved) (moved)
Open
Created Jan 18, 2019 by David Fifield@dcf

Make websocket server tolerant of HTTP/2

The Snowflake websocket server, inherited from flash proxy, assumes that the incoming http.ResponseWriter implements the http.Hijacker interface, which HTTP/2 connections do not.

It causes a panic in the log when you connect to the server with e.g. curl:

2019/01/18 18:56:29 http2: panic serving X.X.X.X:YYYY: interface conversion: *http2.responseWriter is not http.Hijacker: missing method Hijack

I'm not sure if WebSocket connections from browsers use HTTP/2 yet or not, but in any case we should handle it gracefully.

My first inclination is to see if porting to gorilla/websocket fixes this and #28726 (moved).

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking