Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #29223

Closed (moved)
Open
Opened Jan 30, 2019 by Nick Mathewson@nickm🥄

List canonical abbreviations to use in Tor functions and identifiers

We often don't abbreviate things in our function names and global identifiers. This leads to beautiful things like "router_get_mutable_consensus_status_by_descriptor_digest" and "signed_descs_update_status_from_consensus_networkstatus" and "networkstatus_consensus_can_use_multiple_directories".

What's more, when we do abbreviate, we often do so inconsistently: cfg versus config, con vs conn, orconn vs or_conn, and so on.

We should specify which abbreviations we want to standardize, and converge on those.

It is most important to do this for identifiers that are visible across modules, followed by identifiers that are global within a module. I don't think we need to do this for local variables.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.4.4.x-final
Milestone
Tor: 0.4.4.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#29223