Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #2927

Closed (moved)
(moved)
Open
Created Apr 15, 2011 by George Kadianakis@asn

Tor doesn't overwrite rotated keys

Tor doesn't zero out rotated onion keys, or rotated x509s and currently leaves them into memory for anyone to have fun with them.

The fact that Tor uses PFS TLS ciphersuites saves the day, but still sensitive stuff should be overwritten to be on the safe side.

Onion keys should get memsetted somewhere around the crypto_free_pk_env(lastonionkey); of rotate_onion_key()

and TLS certificates should get memsetted in: tor_tls_context_decref().

OpenSSL has functions that clean keys correctly, iirc.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking