Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #29424

Closed (moved)
Open
Opened Feb 07, 2019 by Iain Learmonth@irl

Differentiate between internal and external links

Currently Tor Metrics opens external links in a new tab. This is bad for two reasons:

  1. It gives external pages access to window.opener.location which could be used to redirect Tor Metrics users discreetly to a non-Tor Metrics site that does malicious things but looks like Tor Metrics
  2. It is bad for accessibility where users may use assistive technology that is upset when new tabs appear
  3. It is bad for users that might not want new tabs all over the place and are perfectly capable of using the back button

It would still be good to be able to distinguish visually where there are external vs. internal links. I will leave the actual design/implementation up to UX people as I have no suggestions that I think are great.

The following StackOverflow post talks about a CSS selector that can be used for external links:

https://stackoverflow.com/questions/5379752/css-style-external-links

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#29424