memory leak: protover_contains_long_protocol_names in protover.c calls parse_protocol_list, but doesn't free smartlist returned (treats it as a boolean)
The function parse_protocol_list in protover.c allocates a smartlist, and returns a pointer to the smartlist as long as there are no parse errors. The funcction protover_contains_long_protocol_names calls the former, but should capture and delete the returned smartlist if it is not null.
I searched the database for these function names and they didn't show up, so I assume this is unreported and still a problem. I apologize if I missed it somehow.
Trac:
Username: drjohnson1984
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information