Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #29559

Closed (moved)
(moved)
Open
Created Feb 22, 2019 by David Fifield@dcf

meek-client-torbrowser should exit on stdin close, even while waiting on browser output

Edit the browser extension not to output the meek-http-helper: listen line, or hack meek-client-torbrowser to break grepHelperAddress. Start Tor Launcher, select meek, and Connect. Now Cancel and exit Tor Browser. The bug is that meek-client-torbrowser and its child process firefox will continue running.

It happens because meek-client-torbrowser's TOR_PT_EXIT_ON_STDIN_CLOSE and SIGTERM logic happen only after grepHelperAddr. meek-client-torbrowser should pay attention to its stdin the whole time so that it can exit correctly in this case.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking