Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #29818
Closed (moved) (moved)
Open
Issue created Mar 19, 2019 by Mark Smith@mcs

adapt #13379 patch for 68esr

In https://bugzilla.mozilla.org/show_bug.cgi?id=1434033, Mozilla removed the use of LD_LIBRARY_PATH (which is used in non-macOS and non-Windows Firefox to ensure that the updater can locate NSS related shared libraries). Instead, the Firefox build now adds -rpath=$ORIGIN in LDFLAGS.

For Tor Browser, we need a similar solution for Windows and macOS because we define MAR_NSS on all platforms (we define MAR_NSS so that we use NSS for MAR-related crypto on all platforms rather than relying on OS-provided libraries). Therefore, we will need to adapt our #13379 (moved) patch to account for Mozilla's change.

Current (Tor Browser 8.5a9) patch: https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-browser-60.6.0esr-8.5-1&id=c17b8a3fbcd19230706f295a00ce955c1bcf90b9

Related Firefox bugs: https://bugzilla.mozilla.org/show_bug.cgi?id=1434033 https://bugzilla.mozilla.org/show_bug.cgi?id=1434666

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking