Skip to content

GitLab

Trac
Trac

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Closed (moved)
Opened by teor@teor

Test circuitpadding with zero monotonic time deltas, and fix any bugs

Any pre-ratchet monotime increment can be zero or negative, because the Windows API and gettimeofday() don't provide monotonic source times.

So after Tor applies the ratchet, any number of calls to the monotonic time functions may return the same value.

We have seen this happen when:

We know it can also happen when:

  • Tor uses gettimeofday() and a ratchet to emulate monotime, and the wall clock time goes backwards

But these circumstances are rare:

  1. unit tests like test_util_monotonic_time() pass on Linux, macOS, and Windows CI
  2. Sleeping Windows boxes don't care about padding timing accuracy
  3. macOS VMs are rare
  4. Systems without monotime functions are rare, and clock changes on those systems are also rare
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information