Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #30458

Closed (moved)
Open
Opened May 09, 2019 by Taylor Yu@catalyst

CID 1444999 dead trunnel-generated code

This one looks valid to me, but also looks like it will need a trunnel change to the code generation for handling unions.

*** CID 1444999:  Control flow issues  (DEADCODE)
/src/trunnel/sendme.c: 244 in sendme_cell_encode()
238             break;
239         }
240         /* Write the length field back to data_len */
241         trunnel_assert(written >= written_before_union);
242     #if UINT16_MAX < SIZE_MAX
243         if (written - written_before_union > UINT16_MAX)
>>>     CID 1444999:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach this statement: "goto check_failed;".
244           goto check_failed;
245     #endif
246         trunnel_set_uint16(backptr_data_len, trunnel_htons(written - written_before_union));
247       }
248     
249     
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#30458