token_bucket_ctr_adjust() does not convert rate to step
In #30687 (moved), we created a single-counter token bucket token_bucket_ctr.
token_bucket_rw_adjust() calls rate_per_sec_to_rate_per_step(rate), but token_bucket_ctr_adjust() does not.
I suggest we fix this bug by moving rate_per_sec_to_rate_per_step(rate) into token_bucket_cfg_init(). And we should add some documentation that explains the difference between rate and burst.
Gaba, this is sponsor 31-must, because it is a bug fix on sponsor 31 code that has already been merged.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information