Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #31608

Closed (moved)
(moved)
Open
Created Sep 03, 2019 by David Goulet@dgoulet🆘

circuit_state_publish() never triggers when a new origin circuit is created

In origin_circuit_init(), we change the circuit state before allocating the build_state but also before a purpose is set.

This means that circuit_state_publish() located in circuit_set_state() is never called for a new circuit because CIRCUIT_IS_ORIGIN() doesn't return true.

Which in turn, by chance I believe, made this NULL deref on build_state to never happen.

This should be fixed regardless.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking