Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #31638

Closed (moved)
Open
Opened Sep 05, 2019 by teor@teor

config: Always check for valid function arguments at the start of each function

Some of the new and refactored config functions check if their arguments are NULL (or otherwise valid). Others don't.

We should consistently check for valid arguments at the start of every function. If there are any unusual validity conditions, we should explain them in a function comment.

If we skip validation, we should explain why in a comment, where we would usually do validation.

I'm also open to general exceptions. I'm not sure if we have coding standards here. But it would be nice to catch as many future bugs as we can, as early as we can.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#31638