Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #31707

Closed (moved)
Open
Opened Sep 11, 2019 by teor@teor

Better handling and UX for missing and expired guard descriptors

Split off #31657 (moved):

Replying to teor:

How do we reliably detect pathological cases? Suppress the message, until it occurs a few times within a short timeframe?

dgoulet:

That's a good question I don't have an answer for.

Unfortunately, I don't think that's the kind of message that occurs multiple times, looking at #30746 (moved) (and friends) this seems to be able to cause havoc with just a single repeatition.

I'm not sure why this is the case, since router_have_minimum_dir_info() seems to be called all the time and that should eventually call entry_guards_get_err_str_if_dir_info_missing() which is the source of the log message... Things are kinda messy between these two functions tho, so it's kinda hard to understand what's the issue.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#31707