Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #31713

Closed (moved)
Open
Opened Sep 12, 2019 by teor@teor

Automatically run the autostyle scripts before every commit

Let's try out our auto-formatting workflow by running: scripts/maint/rectify_include_paths.py . before every commit.

We occasionally miss include paths: https://github.com/torproject/tor/pull/1319/commits/a90d1918af5d2b6c6e6dd2c0797f8a63d4042bfa

We should only ever run auto-formatting on master.

Edited to add:

We'll need to use a similar strategy to practracker, where we check for the presence of a file before running the autostyle scripts.

We can't use "make autostyle" directly, because some commit directories haven't run configure, so they don't have a Makefile. Instead, we should do what we do with all the other hook scripts, and copy the code from "make autostyle" to the hook. (Or even better, create a style script, and call it from "make autostyle" and the hook.)

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#31713