Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #3175

Closed (moved)
(moved)
Open
Created May 14, 2011 by Robert Ransom@rransom

smartlist_string_num_isin's buffer is too short

smartlist_string_num_isin converts an int to a 15-character or shorter string. Its 16-byte buffer is not long enough to handle all 64-bit ints (-2^63^ is 20 characters long, so the buffer would need to be at least 21 bytes long).

We currently only use this function for (16-bit) TCP port numbers, so this bug doesn't actually hurt anything, but we shouldn't leave an even slightly incorrect function lying around to bite us later.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking