Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #32060

Closed (moved)
Open
Opened Oct 14, 2019 by teor@teor

CID 1454761: wrong type passed to unlock_cb_buf()?

Maybe it should be void *cb_buf[]

CID 1454761:  Incorrect expression  (SIZEOF_MISMATCH)
/src/lib/err/backtrace.c: 107 in unlock_cb_buf()
101     }
102     
103     /** Unlock the static stack pointer buffer. */
104     static void
105     unlock_cb_buf(void *cb_buf)
106     {
   CID 1454761:  Incorrect expression  (SIZEOF_MISMATCH)
   Passing argument "cb_buf" of type "void *" and argument "2048UL /* 256 * sizeof (void *) */" to function "memset" is suspicious.
107       memset(cb_buf, 0, SIZEOF_CB_BUF);
108       pthread_mutex_unlock(&cb_buf_mutex);
109     }
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.4.2.x-final
Milestone
Tor: 0.4.2.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#32060