Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #32094
Closed (moved) (moved)
Open
Issue created Oct 15, 2019 by David Goulet@dgoulet🐼

hs-v3: Stop using ip->circuit_established flag

Since #31548 (moved), where we forgot to look if the service intro circuit was established, we rely on ip->circuit_established flag to know if we can use the IP (and in many other places as well).

However, this is a bit of a "duplication" of effort because we have the HS circuitmap that keeps all the intro circuits conveniently indexed by IP auth key.

When a circuit closes or is repurposed, that HS map is cleaned up with hs_circ_cleanup() so regardless what caused the circuit to disappear, our map will always be updated properly.

I believe we should stop relying on the ip->circuit_established flag so in the future we don't get out of sync with the map by mistake or assume state based solely on this flag. The HS map is the only real valid state we should be looking at for HS circuit state.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking