Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #32124

Closed (moved)
Open
Opened Oct 17, 2019 by teor@teor

Interpret --disable-module-dirauth=no correctly

Currently, we treat --disable-module-dirauth=no as enabling the C macro, but disabling the Makefile variable.

Apparently lots of people make this mistake:

The most common mistake for this macro is to consider the two actions as action-if-enabled and action-if-disabled.

This is not the case!

Since using --disable-foo or --enable-foo=no are equivalent, for the macro, you cannot really use this macro with those meanings. 

https://autotools.io/autoconf/arguments.html

I don't know if we should backport this change, it just didn't work before, so maybe it should just go in master?

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.4.2.x-final
Milestone
Tor: 0.4.2.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#32124