Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #32356

Closed (moved)
Open
Opened Nov 01, 2019 by David Goulet@dgoulet🐋

hs-v3: Memory leak in rend_client_get_random_intro_impl()

From coverity report:

** CID 1455168:  Resource leaks  (RESOURCE_LEAK)
/src/feature/rend/rendclient.c: 1061 in rend_client_get_random_intro_impl()


________________________________________________________________________________________________________
*** CID 1455168:  Resource leaks  (RESOURCE_LEAK)
/src/feature/rend/rendclient.c: 1061 in rend_client_get_random_intro_impl()
1055       usable_nodes = smartlist_new();
1056       smartlist_add_all(usable_nodes, entry->parsed->intro_nodes);
1057     
1058       /* Get service ID so we can use it to query the failure cache. If we fail to
1059        * parse it, this cache entry is no good. */
1060       if (BUG(rend_get_service_id(entry->parsed->pk, service_id) < 0)) {
>>>     CID 1455168:  Resource leaks  (RESOURCE_LEAK)
>>>     Variable "usable_nodes" going out of scope leaks the storage it points to.
1061         return NULL;
1062       }

Was just introduced couple days ago.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.4.3.x-final
Milestone
Tor: 0.4.3.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#32356