Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #32357

Closed (moved)
(moved)
Open
Created Nov 01, 2019 by Nick Mathewson@nickm🍬

Coverity reports leak-on-BUG() in rend_client_get_random_intro_impl()

_______________________________________________________________________________________________________
*** CID 1455168:  Resource leaks  (RESOURCE_LEAK)
/src/feature/rend/rendclient.c: 1061 in rend_client_get_random_intro_impl()
1055       usable_nodes = smartlist_new();
1056       smartlist_add_all(usable_nodes, entry->parsed->intro_nodes);
1057     
1058       /* Get service ID so we can use it to query the failure cache. If we fail to
1059        * parse it, this cache entry is no good. */
1060       if (BUG(rend_get_service_id(entry->parsed->pk, service_id) < 0)) {
>>>     CID 1455168:  Resource leaks  (RESOURCE_LEAK)
>>>     Variable "usable_nodes" going out of scope leaks the storage it points to.
1061         return NULL;
1062       }
1063     
1064       /* Remove the intro points that have timed out during this HS
1065        * connection attempt from our list of usable nodes. */
1066       SMARTLIST_FOREACH_BEGIN(usable_nodes, const rend_intro_point_t *, ip) {
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking