Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar

Admin message

GitLab has been upgraded GitLab 16, please report any issues!

  • Legacy
  • TracTrac
  • Issues
  • #32517
Closed (moved) (moved)
Open
Issue created Nov 15, 2019 by Trac@tracbot

make check Message After Testsuite Summary

Ever since I started building Tor from source I've noticed something at the end of the make check command which puzzled me.

For the time being I can't dig deeper, but the problem just got worse when building Tor 0.4.2.4-rc.

Here is what I see after the Testsuite summary for tor 0.4.1.6, which seems nearly identical to what I've been seeing for the past few versions:

perl ./scripts/maint/checkSpace.pl -C \
		./src/lib/*/*.[ch] ./src/core/*/*.[ch] ./src/feature/*/*.[ch] ./src/app/*/*.[ch] ./src/test/*.[ch] ./src/test/*/*.[ch] ./src/tools/*.[ch]
python ./scripts/maint/checkIncludes.py
if command -v shellcheck; then \
	        find ./scripts/ -name "*.sh" -exec shellcheck {} +; \
	        if [ -d "./scripts/test" ]; then \
                        shellcheck ./scripts/test/cov-diff ./scripts/test/coverage; \
                fi; \
	fi

Now building Tor 0.4.2.4-rc I see this after the Testsuite summary:

perl ./scripts/maint/checkSpace.pl -C \
		./src/lib/*/*.[ch] ./src/core/*/*.[ch] ./src/feature/*/*.[ch] ./src/app/*/*.[ch] ./src/test/*.[ch] ./src/test/*/*.[ch] ./src/tools/*.[ch]
python ./scripts/maint/practracker/includes.py .
Unusual pattern permitted.h in ./scripts/maint/practracker/testdata
(warning) problem file-size /src/app/config/or_options_st.h 1121
(warning) problem file-size /src/core/mainloop/connection.c 5575
(warning) problem file-size /src/core/or/connection_edge.c 4601
(warning) problem function-size /src/core/or/connection_edge.c:connection_ap_handshake_rewrite() 193
(warning) problem file-size /src/feature/client/entrynodes.c 3825
(warning) problem function-size /src/feature/control/control_cmd.c:add_onion_helper_keyarg() 117
(warning) problem function-size /src/feature/dircache/dircache.c:directory_handle_command_post() 124
(warning) problem file-size /src/feature/hs/hs_service.c 4182
(warning) problem file-size /src/feature/relay/router.c 3524
(warning) problem function-size /src/feature/rend/rendmid.c:rend_mid_establish_intro_legacy() 105
(warning) problem file-size /src/feature/rend/rendservice.c 4522
(warning) problem function-size /src/feature/rend/rendservice.c:rend_service_receive_introduction() 334
./scripts/maint/checkShellScripts.sh
./scripts/maint/checkShellScripts.sh: Install shellcheck to check shell scripts.

I'm using a Mac.

Trac:
Username: werd

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking